Consult BAZEL_CXXOPTS when auto-detecting local CC toolchain. #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks! Can you pls rebase on top of 2d0e27e pls? |
This allows for passing -stdlib=libc++ to $CC -E when detecting cxx_builtin_include_directories in @local_config_cc//:CROSSTOOL, which is enough to support linking against libc++. $ clang -E -xc++ - -v /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0 /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0 /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/backward /usr/include/clang/8.0.0/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include $ clang -E -xc++ - -v -stdlib=libc++ /usr/lib/llvm-8/bin/../include/c++/v1 /usr/include/clang/8.0.0/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
bazel_cxxopts
branch
from
93497e5 to
d624dad
Compare
|
@hlopko rebased, thanks! FYI, I've got some pushback against vendoring a custom copy of |
|
Thanks! Importing. |
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
This allows for passing -stdlib=libc++ to $CC -E when detecting cxx_builtin_include_directories in @local_config_cc//:CROSSTOOL, which is enough to support linking against libc++. $ clang -E -xc++ - -v /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0 /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0 /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/backward /usr/include/clang/8.0.0/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include $ clang -E -xc++ - -v -stdlib=libc++ /usr/lib/llvm-8/bin/../include/c++/v1 /usr/include/clang/8.0.0/include /usr/local/include /usr/include/x86_64-linux-gnu /usr/include Signed-off-by: Piotr Sikora <piotrsikora@google.com> Closes bazelbuild#7074. PiperOrigin-RevId: 230236020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for passing -stdlib=libc++ to $CC -E when detecting
cxx_builtin_include_directories in @local_config_cc//:CROSSTOOL,
which is enough to support linking against libc++.
$ clang -E -xc++ - -v
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/backward
/usr/include/clang/8.0.0/include
/usr/local/include
/usr/include/x86_64-linux-gnu
/usr/include
$ clang -E -xc++ - -v -stdlib=libc++
/usr/lib/llvm-8/bin/../include/c++/v1
/usr/include/clang/8.0.0/include
/usr/local/include
/usr/include/x86_64-linux-gnu
/usr/include
Signed-off-by: Piotr Sikora piotrsikora@google.com